Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many: take repositories from the "images" library #4554

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Jan 10, 2025

This commit changes the spec file so that most of the repositories are taken from the images library. See images PR#1112 for details.

Note that we still need the -no-auth-keys and the centos-stream symlinks - and we probably need to think about the handling of -no-auth-keys and if it could move under a different "tree" in images or something (like github.com/osbuild/images/data/repositories for the general case and github.com/osbuild/images/data/repositories/no-aux-keys subdir with the same file names or even repositories/for-rhel10 or something like this) but this should be ready for a first round of reviews now.

(see osbuild/images#1112)

@mvo5 mvo5 force-pushed the use-vendor-repos branch 3 times, most recently from 15a7a63 to ad41d86 Compare January 20, 2025 12:35
mvo5 added a commit to mvo5/images that referenced this pull request Jan 29, 2025
This is a mirror of
osbuild/osbuild-composer#4578
to update the gpg keys.

Once osbuild/osbuild-composer#4554 is
merged there should be no drift anymore.
@mvo5 mvo5 force-pushed the use-vendor-repos branch 5 times, most recently from 0a86a28 to e0743e2 Compare January 29, 2025 21:27
github-merge-queue bot pushed a commit to osbuild/images that referenced this pull request Jan 29, 2025
This is a mirror of
osbuild/osbuild-composer#4578
to update the gpg keys.

Once osbuild/osbuild-composer#4554 is
merged there should be no drift anymore.
@mvo5 mvo5 force-pushed the use-vendor-repos branch from e0743e2 to 68b18bb Compare January 30, 2025 08:22
repositories/README.md Outdated Show resolved Hide resolved
@mvo5 mvo5 force-pushed the use-vendor-repos branch from 68b18bb to c4c809d Compare January 30, 2025 09:05
repositories/README.md Outdated Show resolved Hide resolved
@mvo5 mvo5 marked this pull request as ready for review January 30, 2025 09:18
@mvo5 mvo5 requested a review from thozza January 30, 2025 09:18
@mvo5 mvo5 force-pushed the use-vendor-repos branch from c4c809d to 7722d3e Compare January 31, 2025 08:20
@mvo5
Copy link
Contributor Author

mvo5 commented Jan 31, 2025

Note that we added fedora-42 to the repositories in "images" recently (c.f. osbuild/images#1183) - having this PR would mean we get the update automatically :)

osbuild-composer.spec Outdated Show resolved Hide resolved
osbuild-composer.spec Outdated Show resolved Hide resolved
osbuild-composer.spec Outdated Show resolved Hide resolved
@mvo5 mvo5 force-pushed the use-vendor-repos branch 3 times, most recently from 2b04d00 to ed4568c Compare February 5, 2025 15:17
@mvo5 mvo5 requested a review from thozza February 6, 2025 11:43
mvo5 added 3 commits February 6, 2025 14:54
This commit changes the spec file so that most of the repositories
are taken from the `images` library. See images PR#1112 for details.

Note that we still need the -no-auth-keys and the centos-stream
symlinks.
This commit updates the cloudapi test that uses the real repositories
to use the version of those from the "images" library. Composer
no longer carries the default repos.

Note that this can most likely be simplified once
osbuild/images#1179
is merged.
This commit updates the `cross-distro.sh` test to use the
`images`repository to get all the available image definitions.
@mvo5 mvo5 force-pushed the use-vendor-repos branch from ba2953f to fe3b7aa Compare February 6, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants