-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
many: take repositories from the "images" library #4554
Open
mvo5
wants to merge
3
commits into
osbuild:main
Choose a base branch
from
mvo5:use-vendor-repos
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
force-pushed
the
use-vendor-repos
branch
3 times, most recently
from
January 20, 2025 12:35
15a7a63
to
ad41d86
Compare
mvo5
added a commit
to mvo5/images
that referenced
this pull request
Jan 29, 2025
This is a mirror of osbuild/osbuild-composer#4578 to update the gpg keys. Once osbuild/osbuild-composer#4554 is merged there should be no drift anymore.
mvo5
force-pushed
the
use-vendor-repos
branch
5 times, most recently
from
January 29, 2025 21:27
0a86a28
to
e0743e2
Compare
github-merge-queue bot
pushed a commit
to osbuild/images
that referenced
this pull request
Jan 29, 2025
This is a mirror of osbuild/osbuild-composer#4578 to update the gpg keys. Once osbuild/osbuild-composer#4554 is merged there should be no drift anymore.
mvo5
force-pushed
the
use-vendor-repos
branch
from
January 30, 2025 08:22
e0743e2
to
68b18bb
Compare
mvo5
commented
Jan 30, 2025
mvo5
force-pushed
the
use-vendor-repos
branch
from
January 30, 2025 09:05
68b18bb
to
c4c809d
Compare
mvo5
commented
Jan 30, 2025
mvo5
force-pushed
the
use-vendor-repos
branch
from
January 31, 2025 08:20
c4c809d
to
7722d3e
Compare
Note that we added fedora-42 to the repositories in "images" recently (c.f. osbuild/images#1183) - having this PR would mean we get the update automatically :) |
thozza
reviewed
Jan 31, 2025
mvo5
force-pushed
the
use-vendor-repos
branch
3 times, most recently
from
February 5, 2025 15:17
2b04d00
to
ed4568c
Compare
This commit changes the spec file so that most of the repositories are taken from the `images` library. See images PR#1112 for details. Note that we still need the -no-auth-keys and the centos-stream symlinks.
This commit updates the cloudapi test that uses the real repositories to use the version of those from the "images" library. Composer no longer carries the default repos. Note that this can most likely be simplified once osbuild/images#1179 is merged.
This commit updates the `cross-distro.sh` test to use the `images`repository to get all the available image definitions.
mvo5
force-pushed
the
use-vendor-repos
branch
from
February 6, 2025 13:55
ba2953f
to
fe3b7aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the spec file so that most of the repositories are taken from the
images
library. See images PR#1112 for details.Note that we still need the -no-auth-keys and the centos-stream symlinks - and we probably need to think about the handling of -no-auth-keys and if it could move under a different "tree" in images or something (like github.com/osbuild/images/data/repositories for the general case and github.com/osbuild/images/data/repositories/no-aux-keys subdir with the same file names or even repositories/for-rhel10 or something like this) but this should be ready for a first round of reviews now.
(see osbuild/images#1112)